[06:56:51]
<Yunohost Git/Infra notifications> [my_webapp_ynh] @Wave6677 opened issue #96: Cant edit index.html at all without encountering a 403 Forbidden message https://github.com/YunoHost-Apps/my_webapp_ynh/issues/96
[07:23:20]
<Yunohost Git/Infra notifications> [my_webapp_ynh] @Wave6677 edited issue #96: Cant edit index.html at all without encountering a 403 Forbidden message https://github.com/YunoHost-Apps/my_webapp_ynh/issues/96
[09:07:12]
<Guillaume Bouzige> hello yunohost app devs,
i am trying to finish re-packaging an existing app cryptpad and i got rejected by ci tests like https://github.com/YunoHost-Apps/cryptpad_ynh/pull/144#issuecomment-1279473288
i am not sure where to start looking to solve those, I guess it might be prtty standard. no ?
[09:27:16]
<Tag> Have a look at this https://ci-apps-dev.yunohost.org/ci/job/3768
In the logs, you can see errors on the Backup/Restore test
[09:36:44]
<Guillaume Bouzige> aaahhh thanks !
[11:32:38]
<Guillaume Bouzige> ok I very happy to know that the extra sandbox domain is making issue but how to I move from there `yunohost.utils.error.YunohostValidationError: Domain 'sandbox-sub.domain.tld' unknown` do I need to add the domain creation in the restore script and all other modification i did in install script ?
[11:35:04]
<Aleks (he/him/il/lui)> oh god ...
[11:35:40]
<Aleks (he/him/il/lui)> well i realize that's a mess because the permissions are restored prior to running the restore script
[11:36:06]
<Aleks (he/him/il/lui)> but when restoring the permission, yunohost will validate the consistency of the permission, among which that the domain exists
[11:36:17]
<Aleks (he/him/il/lui)> but since it won't exist yet ... this crashes
[11:36:31]
<Guillaume Bouzige> inception ?
[11:36:46]
<Aleks (he/him/il/lui)> yeah or egg-and-chicken
[11:37:03]
<Guillaume Bouzige> hum but I do need my sandbox domain snifg
[11:41:12]
<Aleks (he/him/il/lui)> é_è
[11:41:44]
<Aleks (he/him/il/lui)> maybe that's why no app does a `yunohost domain add` from inside the app itself
[11:42:26]
<Aleks (he/him/il/lui)> i guess the workaround is to rework the whole thing and instead ask the admin to manually create the domain beforehand and check that the domain does exists at the beginning of the install / upgrade / restore scripts ...
[11:42:32]
<Aleks (he/him/il/lui)> but that's kinda annoying in terms of UX
[11:42:43]
<Guillaume Bouzige> very
[11:42:46]
<Guillaume Bouzige> also for admin
[11:43:14]
<Guillaume Bouzige> there must be another way around
[12:07:33]
<limezy> > <@Alekswag:matrix.org> but that's kinda annoying in terms of UX
The outline app, that I have packaged, requires no less than 3 full domains to be installed. I do as you said, that is check if these are installed before launching the script. Nobody has complained so far 😅
[12:08:59]
<limezy> Sorry, I intended to reply to Guillaume Bouzige, not Aleks
[12:09:25]
<Guillaume Bouzige> I see
[12:10:29]
<limezy> I think people understand quite well that some app may need internal dependencies, each requiring its own domain, for technical reasons (in my case, one for the app, one for the auth, one for the S3 storage)
[12:11:02]
<limezy> And adding a subdomain with Yunohost is usually free, easy and quick
[12:11:53]
<Guillaume Bouzige> yes
[12:13:08]
<limezy> You could also create a “fake” micro app, and trigger the installation of that micro app with the main app (this is what I do in practice). You would benefit from the system protection, by having Yunohost aware that an app is already using that domain
[12:13:42]
<limezy> That’s probably better as it would prevent people from installing something else on that same domain
[12:14:25]
<limezy> You may have a look at how things are done for Outline (mainly a copy paste from other implementations made by the pro packagers out there)
[12:14:53]
<Guillaume Bouzige> thanks @limezy
[12:15:35]
<Guillaume Bouzige> how does the restore / upgrade do with the 'fake' micro app solution ?
[12:17:14]
<Guillaume Bouzige> so the fake micro app is empty but just ship with the extra domain i need for my main app ?
[12:21:08]
<limezy> Yep I would base it on redirect app maybe ?
[12:23:10]
<Guillaume Bouzige> I think someone already did an app cryptpad_sandbox
[12:24:47]
<Guillaume Bouzige> ericgaspar did https://github.com/YunoHost-Apps/cryptpad_sandboxing_ynh I can maybe continue from there...
[12:25:23]
<Guillaume Bouzige> so people will have to install the sandbox app first and then the main app
[12:25:42]
<Guillaume Bouzige> that is the idea ? or I install directly the app within the script ?
[12:27:34]
<Guillaume Bouzige> like with minio in outline https://github.com/YunoHost-Apps/outline_ynh/blob/61b3e0c75483d789a8c8729c58dcc601bf65304a/scripts/install#L59
[12:42:37]
<balaa> > hello yunohost app devs,
>
> i am trying to finish re-packaging an existing app cryptpad and i got rejected by ci tests like https://github.com/YunoHost-Apps/cryptpad_ynh/pull/144#issuecomment-1279473288
>
> i am not sure where to start looking to solve those, I guess it might be prtty standard. no ?
Current cryptpad is broken, no?
[12:43:00]
<Guillaume Bouzige> > <@balaa:ether.ai> Current cryptpad is broken, no?
current cryptpad has always been broken
[12:44:22]
<limezy> > that is the idea ? or I install directly the app within the script ?
Yep. Within the script. Like Minio
[16:33:00]
<eric_G[m]> > so people will have to install the sandbox app first and then the main app
you can install the sandboxing app like so : https://github.com/YunoHost-Apps/cryptpad_ynh/blob/60811511cc698ea9ea5d19057e906a070a6c4f37/scripts/install#L71-L81
[18:10:59]
<Émy - OniriCorpe> https://aria.im/_matrix/media/v1/download/im.emelyne.eu/WiHqMtzIzYGoKnwbYMXwjCkd
[18:11:01]
<Émy - OniriCorpe> sur YunoHost 11.0.10 avec toutes les migrations déjà faites .__.
[18:11:39]
<Émy - OniriCorpe> (j'ai vérifié, oui toutes mes migrations sont faites, y'en a pas eu de nouvelles depuis le passage à debian 11)
[19:12:34]
<Tag> Mmmmh tu peux partager ton /etc/yunohost/migrations.yml ?
[19:12:53]
<Tag> Émy - OniriCorpe: `/etc/yunohost/migrations.yaml` * pardon
[19:14:03]
<Émy - OniriCorpe> ```
migrations:
0015_migrate_to_buster: skipped
0016_php70_to_php73_pools: skipped
0017_postgresql_9p6_to_11: skipped
0018_xtable_to_nftable: skipped
0019_extend_permissions_features: done
0020_ssh_sftp_permissions: done
0021_migrate_to_bullseye: done
0022_php73_to_php74_pools: done
0023_postgresql_11_to_13: done
0024_rebuild_python_venv: done
```
[19:14:17]
<Émy - OniriCorpe> c'est affiché que depuis la maj 11.0.10
[19:14:29]
<Tag> ah
[19:17:51]
<Tag> Something to do with this commit I guess https://github.com/YunoHost/yunohost/commit/86e45f9cbca3dabff11bd4e25cb383cbac6c7ca6
[19:23:11]
<Tag> And the return of `yunohost tools shell -c "from yunohost.tools import tools_migrations_list; print(tools_migrations_list(pending=True))"` ?
[19:35:42]
<Émy - OniriCorpe> > <@tag:lostpod.me> And the return of `yunohost tools shell -c "from yunohost.tools import tools_migrations_list; print(tools_migrations_list(pending=True))"` ?
`{'migrations': []}`
[20:21:34]
<Yunohost Git/Infra notifications> [wordpress_ynh] @tituspijean commented on issue #192 Add auto-updater and reimplement config panel: Using my mighty contributor power to merge. https://github.com/YunoHost-Apps/wordpress_ynh/pull/192#issuecomment-1281445171
[20:21:44]
<Yunohost Git/Infra notifications> [wordpress_ynh] @tituspijean merged pull request #192: Add auto-updater and reimplement config panel https://github.com/YunoHost-Apps/wordpress_ynh/pull/192
[20:21:44]
<Yunohost Git/Infra notifications> [wordpress_ynh] @tituspijean pushed 11 commits to master: https://github.com/YunoHost-Apps/wordpress_ynh/compare/28237e328053...d31fd5519e6c
[20:21:47]
<Yunohost Git/Infra notifications> [wordpress_ynh/master] Bump package version - tituspijean
[20:21:50]
<Yunohost Git/Infra notifications> [wordpress_ynh] @yunohost-bot pushed 1 commit to master: Auto-update README https://github.com/YunoHost-Apps/wordpress_ynh/commit/7bec7d7700263eaad08f8629f9400324abbde765
[20:21:51]
<Yunohost Git/Infra notifications> [wordpress_ynh/master] Merge pull request #192 from YunoHost-Apps/testing - tituspijean
[20:21:51]
<Yunohost Git/Infra notifications> [wordpress_ynh/master] Auto-update README - yunohost-bot
[20:36:44]
<Tag> MMmh ouais je pense que le test dans la webadmin est peut être pas bon mais je peux pas trop débug là tout de suite
[20:36:46]
<Tag> https://github.com/YunoHost/yunohost-admin/commit/f7d7bcec
[20:37:37]
<Tag> https://github.com/YunoHost/yunohost-admin/blob/f7d7bcec2d1f9715a8e297e7408d6c3013a800c2/app/src/views/update/SystemUpdate.vue#L98
Je crois qu'ici `pending_migrations` est un Dict et pas un tableau
[20:39:56]
<Tag> Le code python retourne un Dict `{"migrations":[]}` et la webadmin s'attend directement à un tableau
[20:54:30]
<Yunohost Git/Infra notifications> [hextris_ynh] @yalh76 approved pull request #38 Testing https://github.com/YunoHost-Apps/hextris_ynh/pull/38#pullrequestreview-1144798810
[21:04:57]
<Yunohost Git/Infra notifications> [my_webapp_ynh] @tituspijean commented on issue #96 Cant edit index.html at all without encountering a 403 Forbidden message: > chown 997:33 index.html Whats the output of id 997 and id 33, and whats the output of ls -la /var/www/my_webap... https://github.com/YunoHost-Apps/my_webapp_ynh/issues/96#issuecomment-1281492921
[21:05:56]
<Aleks (he/him/il/lui)> > <@oniricorpe:im.emelyne.eu> sur YunoHost 11.0.10 avec toutes les migrations déjà faites .__.
oopsy jétoupété ?
[21:06:56]
<Aleks (he/him/il/lui)> ah moui j'ai le même pb lonle /o\
[21:07:32]
<Aleks (he/him/il/lui)> >TypeError: a is undefined
dans la console js
[21:07:36]
<Aleks (he/him/il/lui)> zgrbml
[21:09:09]
<Aleks (he/him/il/lui)> ah c'est genre yunohost-api a pas été riboute
[21:09:50]
<Aleks (he/him/il/lui)> hm du coup ce serait genre le nouveau mécanisme de maj qui marche pas comme y fo
[21:11:41]
<Aleks (he/him/il/lui)> > <@oniricorpe:im.emelyne.eu> sur YunoHost 11.0.10 avec toutes les migrations déjà faites .__.
mouai du coup le workaround c'est de manuellement redémarrer `yunohost-api`, ce qui aurait dû être fait automagiquement pendant la maj
[21:25:39]
<Aleks (he/him/il/lui)> à cause de https://github.com/YunoHost/yunohost/commit/472e92507763188d4f57ee3eba334dfd37e7172d é_è
[21:28:02]
<Tag> ah mmh j'ai tout mal compris alors
[21:32:40]
<Aleks (he/him/il/lui)> le nouveau code est OK a priori, c'est "juste" que yunohost-api a pas été restart après la maj, ce qui est un peu relou parce que je pensais que ce code marchait, mais du coup là meme si je le fix maintenant il faut quand même que les gens mette à jour une fois pour que *la fois suivante* qu'iels upgradent ça fasse bien le riboute :|
[21:40:56]
<Yunohost Git/Infra notifications> [hextris_ynh] @ericgaspar merged pull request #38: Testing https://github.com/YunoHost-Apps/hextris_ynh/pull/38
[21:40:56]
<Yunohost Git/Infra notifications> [hextris_ynh] @ericgaspar pushed 1 commit to master: update README * Fix linter * Auto-update README Co-authored-by: yunohost-bot <yunohost@yunohost.org> * Auto-update README * Appy last example_ynh * Auto-update README Co-authored-by: Yunohost-Bot <unknown> Co-authored-by: yunohost-bot <yunohost@yunohost.org> Co-authored-by: yalh76 <yalh@yahoo.com>... https://github.com/YunoHost-Apps/hextris_ynh/commit/82d7a06fc35a764a8fb4de983485c1c0291211f8