Thursday, October 27, 2022
apps@conference.yunohost.org
October
Mon Tue Wed Thu Fri Sat Sun
          1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
           

[08:12:34] <Yunohost Git/Infra notifications> [wordpress_ynh] @github-actions[bot] pushed 1 commit to ci-auto-update-v6.0.3: Upgrade to version 6.0.3 https://github.com/YunoHost-Apps/wordpress_ynh/commit/5a3f4dabfa3af49fa5ff80d636ee070ebb547498
[08:12:35] <Yunohost Git/Infra notifications> [wordpress_ynh] @yunohost-bot pushed 1 commit to ci-auto-update-v6.0.3: Auto-update README https://github.com/YunoHost-Apps/wordpress_ynh/commit/240a28170bcaede20a8ab365c10afaec546dcaea
[08:43:43] <eric_G[m]> First app tested with YunoHost 11.1: bookstack_ynh
[08:45:02] <eric_G[m]> There is an issue with PHP helper that is not able to replace `$finalpath` and `$final_path` variable
[08:45:42] <eric_G[m]> this is fixed by replacing `$finalpath` and `$final_path`by $install_dir
[08:48:04] <eric_G[m]> The app is installed but it doesn't show in the user interface... (pas de tuile...)
[08:49:05] <eric_G[m]> Aleks (he/him/il/lui): ^ what is the best place to report this?
[09:11:52] <eric_G[m]> also, the script `convert_app_to_packaging_v2.py` replaced `__FINALPATH__` by `__INSTALL_DIR__` in `nginx.conf` and `systemd.service` file but not in the `config_panel.toml` file.
[09:45:44] <Guillaume Bouzige> hello appteam,

can `ynh_write_var_in_file` be able to modify a var in `/etc/ssowat/conf.json` ?
[09:49:23] <Aleks (he/him/il/lui)> Uuuugh
[09:49:42] <Aleks (he/him/il/lui)> Maybe but uuuuuuugh
[09:49:55] <Guillaume Bouzige> yeah I know and my key shall be something like `--key=cryptpad.main[uris]`
[09:50:07] <Guillaume Bouzige> I am so stuck....
[09:59:43] <Guillaume Bouzige> > <@Alekswag:matrix.org> maybe the issue is around here https://github.com/YunoHost/yunohost/blob/dev/src/permission.py#L920

it is the `path` var being empty the `sanitized_url` is adding the trailing slash
[10:00:44] <Guillaume Bouzige> another to look at it might be why does ssowat refuse access if there is a trailing slash ?
[10:01:14] <Guillaume Bouzige> or is it because of the conf of two domains in one app that confuse him...
[10:01:29] <Guillaume Bouzige> what about using persistent conf instead ?
[10:38:36] <Guillaume Bouzige> funny enough it didn't complain but didn't modify the domain neither
```
408184 DEBUG + ynh_write_var_in_file --file=/etc/ssowat/conf.json --key=uris --value=sandbox-cryptpad.domain.com/ --after=sandbox-cryptpad.domain.com
408184 DEBUG + local legacy_args=fkva
408184 DEBUG + args_array=(['f']='file=' ['k']='key=' ['v']='value=' ['a']='after=')
408185 DEBUG + local -A args_array
408185 DEBUG + local file
408185 DEBUG + local key
408185 DEBUG + local value
408185 DEBUG + local after
408185 DEBUG + ynh_handle_getopts_args --file=/etc/ssowat/conf.json --key=uris --value=sandbox-cryptpad.domain.com/ --after=sandbox-cryptpad.domain.com
408185 DEBUG + set +o xtrace
408263 DEBUG + after=sandbox-cryptpad.ddataa.email
408264 DEBUG + [[ -f /etc/ssowat/conf.json ]]
408264 DEBUG + set +o xtrace
```
[10:38:50] <Guillaume Bouzige> funny enough it didn't complain but didn't modify the domain neither
```
408184 DEBUG + ynh_write_var_in_file --file=/etc/ssowat/conf.json --key=uris --value=sandbox-cryptpad.domain.com/ --after=sandbox-cryptpad.domain.com
408184 DEBUG + local legacy_args=fkva
408184 DEBUG + args_array=(['f']='file=' ['k']='key=' ['v']='value=' ['a']='after=')
408185 DEBUG + local -A args_array
408185 DEBUG + local file
408185 DEBUG + local key
408185 DEBUG + local value
408185 DEBUG + local after
408185 DEBUG + ynh_handle_getopts_args --file=/etc/ssowat/conf.json --key=uris --value=sandbox-cryptpad.domain.com/ --after=sandbox-cryptpad.domain.com
408185 DEBUG + set +o xtrace
408263 DEBUG + after=sandbox-cryptpad.domain.com
408264 DEBUG + [[ -f /etc/ssowat/conf.json ]]
408264 DEBUG + set +o xtrace
```
[10:41:32] <Guillaume Bouzige> I dont think rewriting ssowat conf is a great idea tbh
[11:01:44] <Aleks (he/him/il/lui)> > another to look at it might be why does ssowat refuse access if there is a trailing slash ?

yeah indeed
[11:07:04] <Guillaume Bouzige> where can I try to digg that way ?
[11:07:52] <Guillaume Bouzige> is not the code that build the conf but the one that read the conf...
[11:24:19] <Aleks (he/him/il/lui)> It's somewhere either in https://github.com/YunoHost/SSOwat/blob/dev/helpers.lua or https://github.com/YunoHost/SSOwat/blob/dev/access.lua :/
[20:23:37] <Yunohost Git/Infra notifications> [nextcloud_ynh] @grubshka opened issue #520: Upgrade error from (21? / 22) to 24 https://github.com/YunoHost-Apps/nextcloud_ynh/issues/520