[00:08:13]
<Yunohost Git/Infra notifications> [nextcloud_ynh] @OniriCorpe commented on issue #542 changing the time between cron runs to the recommended value of 5 min: testme https://github.com/YunoHost-Apps/nextcloud_ynh/pull/542#issuecomment-1368571738
[00:08:17]
<Yunohost Git/Infra notifications> [nextcloud_ynh] @yunohost-bot commented on issue #542 changing the time between cron runs to the recommended value of 5 min: :stuck_out_tongue_winking_eye:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-dev.yunohost.org/ci/ap... https://github.com/YunoHost-Apps/nextcloud_ynh/pull/542#issuecomment-1368571754
[00:08:17]
<Yunohost Git/Infra notifications> [nextcloud_ynh] @OniriCorpe commented on issue #542 changing the time between cron runs to the recommended value of 5 min: testme https://github.com/YunoHost-Apps/nextcloud_ynh/pull/542#issuecomment-1368571738
[07:39:00]
<Yunohost Git/Infra notifications> [gitlab_ynh] @kay0u pushed 1 commit to testing: 15.7.0 https://github.com/YunoHost-Apps/gitlab_ynh/commit/8c9950834e63b80d9deb35aed0fcf068eabfa228
[07:39:01]
<Yunohost Git/Infra notifications> [gitlab_ynh] @yunohost-bot pushed 1 commit to testing: Auto-update README https://github.com/YunoHost-Apps/gitlab_ynh/commit/f4835eb07780f9e7ca83d7558128cbb5db27176d
[07:50:46]
<Yunohost Git/Infra notifications> [gitlab_ynh] @kay0u opened pull request #207: Testing https://github.com/YunoHost-Apps/gitlab_ynh/pull/207
[07:50:46]
<Yunohost Git/Infra notifications> [gitlab_ynh] @kay0u commented on issue #207 Testing: testme https://github.com/YunoHost-Apps/gitlab_ynh/pull/207#issuecomment-1368714485
[07:50:48]
<Yunohost Git/Infra notifications> [gitlab_ynh] @yunohost-bot commented on issue #207 Testing: Meow :cat2:
[[Test Badge](https://img.shields.io/endpoint?url=https://ci-apps-dev.yunohost.org/ci/api/job/4866/badge)](... https://github.com/YunoHost-Apps/gitlab_ynh/pull/207#issuecomment-1368714498
[09:52:21]
<Gérard Collin> > <@melchisedech:matrix.org> Happy New Year to all!
Thanks, you too !
[11:13:31]
<Yunohost Git/Infra notifications> [apps] @ericgaspar created new branch typo
[11:13:31]
<Yunohost Git/Infra notifications> [apps] @ericgaspar pushed 1 commit to typo: Fix typo https://github.com/YunoHost/apps/commit/83ebb27402c2aa8383dd176d74cfef819c9934ea
[11:15:04]
<Yunohost Git/Infra notifications> [apps] @ericgaspar pushed 1 commit to typo: Fix typo https://github.com/YunoHost/apps/commit/bac1ca3e41fb1e604284d2cf2f3c11c4d4a5deef
[11:21:06]
<Yunohost Git/Infra notifications> [apps] @ericgaspar opened pull request #1565: Small typos https://github.com/YunoHost/apps/pull/1565
[11:47:59]
<Yunohost Git/Infra notifications> [apps] @tituspijean approved pull request #1565 Small typos https://github.com/YunoHost/apps/pull/1565#pullrequestreview-1233707697
[11:50:27]
<Yunohost Git/Infra notifications> [apps] @ericgaspar merged pull request #1565: Small typos https://github.com/YunoHost/apps/pull/1565
[11:50:28]
<Yunohost Git/Infra notifications> [apps] @ericgaspar pushed 3 commits to master: https://github.com/YunoHost/apps/compare/eb723fd8376b...1936ac1932b2
[11:50:29]
<Yunohost Git/Infra notifications> [apps] @ericgaspar deleted branch typo
[11:50:32]
<Yunohost Git/Infra notifications> [apps/master] Fix typo - Éric Gaspar
[11:50:35]
<Yunohost Git/Infra notifications> [apps/master] Fix typo - Éric Gaspar
[11:50:38]
<Yunohost Git/Infra notifications> [apps/master] Merge pull request #1565 from YunoHost/typo Small typos - Éric Gaspar
[12:37:34]
<florent> tituspijean: Bad news: https://ci-apps-dev.yunohost.org/ci/job/4868
I get the `!!! Another analyseCI process is currently using the lock ./CI-2.lock !!!` error anew
[12:37:54]
<florent> But good news, I probably also understand the origin of the bug
[12:38:13]
<florent> It happened after I cancelled a CI job
[12:38:26]
<florent> And the last time it happened also after I did that
[12:39:03]
<florent> I bet the cause is that the cancel operation does not release the lock
[12:46:13]
<Yunohost Git/Infra notifications> [CI_package_check] @fflorent commented on issue #47 Job is lock not released: Here are the steps I reproduce and lead to the issue described here: 1. Create a CI job in a PR using testme 2. Wait ... https://github.com/YunoHost/CI_package_check/issues/47#issuecomment-1368917237
[12:46:56]
<florent> Reported here: https://github.com/YunoHost/CI\_package\_check/issues/47#issuecomment-1368917237
[12:47:01]
<florent> (with the hope to help)
[12:50:01]
<Aleks (he/him/il/lui)> yeah the whole thing about cancelling a job definitely isnt lock-aware
[12:50:13]
<Aleks (he/him/il/lui)> the real question is really why did it work in the past hehe
[12:51:08]
<Aleks (he/him/il/lui)> the cancel is handled by yunorunner, but the lock is managed by CI_package_check
[12:51:33]
<Aleks (he/him/il/lui)> we could either hard-code something in yunorunner about the lock, or merging CI_package_check with yunorunner would help properly fixing this too (but requires much more work)
[13:10:51]
<florent> Is cancelling necessary? Or is it nice to have?
[13:11:42]
<florent> I mean, if it's just something just "nice", we could remove the button and assume the users have to wait until it fails
[13:11:53]
<Aleks (he/him/il/lui)> you can live without it but it's pretty annoying, i mean it's not that much complicated to add a dirty line in the python code that deletes the lock when cancelling the job
[13:12:42]
<Aleks (he/him/il/lui)> sometimes a job takes forever to end if you don't cancel it, so between "having the CI broken because of the lock" and "having the CI unusable because the job is taking forever and cant be cancelled", there's not much difference ...
[13:13:00]
<florent> I see
[13:14:22]
<florent> Or could yunorunner send some kill signal to CI_package_check so it removes the lock?
[13:14:47]
<florent> (I don't fully understand the architecture, my idea can be foolish)
[13:15:37]
<Aleks (he/him/il/lui)> yeah could be too
[13:16:36]
<Aleks (he/him/il/lui)> i'm working for $dayjob today, but if you want to have a look the relevant pieces of code are :
- lock thingies in CI_package_check : https://github.com/YunoHost/CI_package_check/blob/master/analyseCI.sh#L41
- the cancellation block in yunorunner : https://github.com/YunoHost/yunorunner/blob/master/run.py#L469 (though I expect somewhere there's a `cancel()` method but I can't find it)
[13:17:52]
<florent> Thanks!
[13:18:36]
<florent> I see in run.py that the cancellation terminate the process
[13:18:40]
<florent> Here: https://github.com/YunoHost/CI_package_check/blob/master/analyseCI.sh#L70-L82
We see that the process only traps term to make a `exit 2`
[13:18:53]
<florent> Can't we just add `trap cleanup TERM`?
[13:20:21]
<florent> That being said, EXIT should handle TERM
[13:20:38]
<florent> please ignore my message, sorry for disturbing ^^'
[13:26:31]
<Aleks (he/him/il/lui)> yeah as far as i understand EXIT retriggers TERM or something ;P
[13:26:43]
<Aleks (he/him/il/lui)> (maybe that's not the case tho idk)
[13:27:48]
<Yunohost Git/Infra notifications> @fflorent forked CI_package_check to fflorent/CI_package_check: https://github.com/fflorent/CI_package_check
[13:28:01]
<Aleks (he/him/il/lui)> zgblfbln i so want to refactor all this mess
[13:28:13]
<Aleks (he/him/il/lui)> but i'm already in the middle of like 2 or 3 other refactorings x_x
[14:14:49]
<florent> From what i see and believe, it should already work :/
[14:16:16]
<Aleks (he/him/il/lui)> you mean with the exit trap thingy ?
[15:16:02]
<Yunohost Git/Infra notifications> [apps] @ericgaspar pushed 8 commits to Remove-ferrit: https://github.com/YunoHost/apps/compare/7fde70a8319f...c4d38e8bb709
[15:16:05]
<Yunohost Git/Infra notifications> [apps/Remove-ferrit] Fix typo - Éric Gaspar
[15:16:08]
<Yunohost Git/Infra notifications> [apps/Remove-ferrit] Merge pull request #1565 from YunoHost/typo Small typos - Éric Gaspar
[15:16:09]
<Yunohost Git/Infra notifications> [apps/Remove-ferrit] Merge branch master into Remove-ferrit - Éric Gaspar
[15:16:24]
<Yunohost Git/Infra notifications> [apps] @ericgaspar pushed 3 commits to master: https://github.com/YunoHost/apps/compare/1936ac1932b2...d79039328f56
[15:16:24]
<Yunohost Git/Infra notifications> [apps] @ericgaspar merged pull request #1563: Remove Ferrit https://github.com/YunoHost/apps/pull/1563
[15:16:27]
<Yunohost Git/Infra notifications> [apps] @ericgaspar deleted branch Remove-ferrit
[15:16:28]
<Yunohost Git/Infra notifications> [apps/master] Update apps.json - ericgaspar
[15:16:31]
<Yunohost Git/Infra notifications> [apps/master] Merge branch master into Remove-ferrit - Éric Gaspar
[15:16:34]
<Yunohost Git/Infra notifications> [apps/master] Merge pull request #1563 from YunoHost/Remove-ferrit Remove Ferrit - Éric Gaspar
[15:58:38]
<Yunohost Git/Infra notifications> @gcollin forked example_ynh to gcollin/example_ynh: https://github.com/gcollin/example_ynh
[16:02:31]
<Yunohost Git/Infra notifications> [example_ynh] @gcollin opened pull request #198: Create application log directory in restore https://github.com/YunoHost/example_ynh/pull/198
[16:09:38]
<Yunohost Git/Infra notifications> @gcollin forked apps to gcollin/yunohost-apps: https://github.com/gcollin/yunohost-apps
[16:12:10]
<Yunohost Git/Infra notifications> [apps] @oiseauroch opened pull request #1566: add statping app https://github.com/YunoHost/apps/pull/1566
[16:16:34]
<Yunohost Git/Infra notifications> [apps] @alexAubin commented on pull request #1566 add statping app: uuuh bro you fucked up the file encoding :| https://github.com/YunoHost/apps/pull/1566#discussion_r1060115695
[16:16:50]
<Yunohost Git/Infra notifications> [apps] @alexAubin commented on pull request #1566 add statping app: also uuuh why change this https://github.com/YunoHost/apps/pull/1566#discussion_r1060115798
[16:21:18]
<Yunohost Git/Infra notifications> [apps] @gcollin opened pull request #1567: Add Mongo-Express server https://github.com/YunoHost/apps/pull/1567
[16:23:01]
<Yunohost Git/Infra notifications> [apps] @gcollin edited pull request #1567: Add Mongo-Express app https://github.com/YunoHost/apps/pull/1567
[16:23:14]
<Yunohost Git/Infra notifications> [apps] @ericgaspar deleted branch ferrit-discontinued
[16:31:54]
<Yunohost Git/Infra notifications> [apps] @ericgaspar commented on issue #1567 Add Mongo-Express app: It would be nice* to add Mongo-Express to the [YunoHost-Apps](https://github.com/YunoHost-Apps) repo * "nice" as in "... https://github.com/YunoHost/apps/pull/1567#issuecomment-1369078568
[16:34:29]
<Yunohost Git/Infra notifications> [apps] @gcollin commented on issue #1567 Add Mongo-Express app: Sure Eric, no problem. Will I be able to update it after or only through PR ? https://github.com/YunoHost/apps/pull/1567#issuecomment-1369079827
[16:45:02]
<Yunohost Git/Infra notifications> [apps] @ericgaspar commented on issue #1567 Add Mongo-Express app: Yes, you will be able to update the app (maintain role) https://github.com/YunoHost/apps/pull/1567#issuecomment-1369084996
[17:02:35]
<Yunohost Git/Infra notifications> [nextcloud_ynh] @lapineige commented on issue #541 augment "opcache.revalidate_freq" from 1 to 30: I would go for an higher value as except during upgrades (which reload them anyway) most of the time there is no reason ... https://github.com/YunoHost-Apps/nextcloud_ynh/pull/541#issuecomment-1369093170
[17:02:38]
<Gérard Collin> > <@yunohostinfra:matrix.org> [apps] @ericgaspar commented on issue #1567 Add Mongo-Express app: Yes, you will be able to update the app (maintain role) https://github.com/YunoHost/apps/pull/1567#issuecomment-1369084996
Ok, can I get access to this org please ? My github user is gcollin, thanks !
[17:03:07]
<Aleks (he/him/il/lui)> sure 👍️
[17:03:09]
<Aleks (he/him/il/lui)> sending an invite
[17:03:40]
<Aleks (he/him/il/lui)> done
[17:09:29]
<Yunohost Git/Infra notifications> [apps] @gcollin commented on issue #1567 Add Mongo-Express app: Ownership transfered https://github.com/YunoHost/apps/pull/1567#issuecomment-1369099177
[17:10:25]
<Yunohost Git/Infra notifications> [apps] @ericgaspar approved pull request #1567 Add Mongo-Express app https://github.com/YunoHost/apps/pull/1567#pullrequestreview-1233912879
[17:11:00]
<Yunohost Git/Infra notifications> [apps] @ericgaspar merged pull request #1567: Add Mongo-Express app https://github.com/YunoHost/apps/pull/1567
[17:11:08]
<Yunohost Git/Infra notifications> [apps] @ericgaspar pushed 3 commits to master: https://github.com/YunoHost/apps/compare/d79039328f56...fa386a4b8036
[17:11:08]
<Yunohost Git/Infra notifications> [apps/master] Add Mongo-Express server - Gérard Collin
[17:11:18]
<Yunohost Git/Infra notifications> [apps/master] Changed app url - Gérard Collin
[17:11:20]
<Yunohost Git/Infra notifications> [apps/master] Merge pull request #1567 from gcollin/master Add Mongo-Express app - Éric Gaspar
[17:15:54]
<Yunohost Git/Infra notifications> [apps] @ericgaspar commented on issue #1567 Add Mongo-Express app: you should rename main to master and creat a testing branch. https://github.com/YunoHost/apps/pull/1567#issuecomment-1369103892
[17:16:22]
<Yunohost Git/Infra notifications> [apps] @ericgaspar commented on issue #1567 Add Mongo-Express app: you should rename main to master and creat a testing branch. https://github.com/YunoHost/apps/pull/1567#issuecomment-1369103892
[17:27:22]
<Yunohost Git/Infra notifications> [apps] @alexAubin commented on issue #1567 Add Mongo-Express app: (Eeeeh not necessarily ... I think having main as the main branch is supported, and at some point in a meeting we disc... https://github.com/YunoHost/apps/pull/1567#issuecomment-1369109105
[17:33:25]
<Yunohost Git/Infra notifications> [apps] @gcollin commented on issue #1567 Add Mongo-Express app: Well, as you wish. The default now for github is main and not master anymore https://github.com/YunoHost/apps/pull/1567#issuecomment-1369111599
[19:09:44]
<florent> > <@Alekswag:matrix.org> you mean with the exit trap thingy ?
Yes!