[06:01:41]
<mcint> https://github.com/YunoHost-Apps/wallabag2_ynh/issues/162
[08:13:59]
<mcint> I've resolved my issue, editing a php file. Not sure where the best place to fix it is. I've reported my fix, more clearly retitled the issue, and left it open for a Wallabag2 app maintainer to (help me/) resolve.
[12:25:39]
<Yunohost Git/Infra notifications> Application ifm stays at level 2 on https://ci-apps.yunohost.org/ci/job/13331
[13:47:39]
<Yunohost Git/Infra notifications> [apps] @ericgaspar pushed 1 commit to gitlist: Update apps.toml ([2dd4c114](https://github.com/YunoHost/apps/commit/2dd4c11499177332932720b714ffa9530d6172d0))
[13:47:40]
<Yunohost Git/Infra notifications> [apps] @ericgaspar created new branch gitlist
[14:07:06]
<Yunohost Git/Infra notifications> [apps] @ericgaspar pushed 1 commit to master: Create gitlist.png ([bd025f5a](https://github.com/YunoHost/apps/commit/bd025f5a39b3b3e65a4bc4cb0dff3d5245bd6fff))
[14:24:00]
<Yunohost Git/Infra notifications> [apps] @ericgaspar opened [pull request #1623](https://github.com/YunoHost/apps/pull/1623): Add GitList to catalog
[14:24:01]
<Yunohost Git/Infra notifications> [apps/master] Merge pull request #1623 from YunoHost/gitlist Add GitList to catalog - Éric Gaspar
[14:24:01]
<Yunohost Git/Infra notifications> [apps] @ericgaspar pushed 2 commits to master ([bd025f5a39b3...de3663e2dcbd](https://github.com/YunoHost/apps/compare/bd025f5a39b3...de3663e2dcbd))
[14:24:01]
<Yunohost Git/Infra notifications> [apps] @ericgaspar deleted branch gitlist
[14:24:01]
<Yunohost Git/Infra notifications> [apps/master] Update apps.toml - Éric Gaspar
[14:24:01]
<Yunohost Git/Infra notifications> [apps] @ericgaspar merged [pull request #1623](https://github.com/YunoHost/apps/pull/1623): Add GitList to catalog
[14:24:01]
<Yunohost Git/Infra notifications> [apps] @tituspijean approved [pull request #1623](https://github.com/YunoHost/apps/pull/1623#pullrequestreview-1274209481) Add GitList to catalog
[14:25:56]
<Yunohost Git/Infra notifications> [apps] @ericgaspar deleted branch logos
[17:33:23]
<Yunohost Git/Infra notifications> [apps] @tituspijean pushed 1 commit to autoupdater-upgrader: Add auto-updater upgrader ([1065f877](https://github.com/YunoHost/apps/commit/1065f877559574d105c181ccf86b20ff178a04c3))
[17:33:23]
<Yunohost Git/Infra notifications> [apps] @tituspijean created new branch autoupdater-upgrader
[17:35:33]
<Yunohost Git/Infra notifications> [apps] @tituspijean opened [pull request #1624](https://github.com/YunoHost/apps/pull/1624): Add auto-updater upgrader
[17:35:58]
<Yunohost Git/Infra notifications> [apps] @tituspijean edited [pull request #1624](https://github.com/YunoHost/apps/pull/1624): Add auto-updater upgrader
[17:37:27]
<tituspijean> and who will update the auto-updater updater?
[17:37:59]
<Yunohost Git/Infra notifications> [apps] @alexAubin approved [pull request #1624](https://github.com/YunoHost/apps/pull/1624#pullrequestreview-1274261262) Add auto-updater upgrader
[17:38:30]
<Aleks (he/him/il/lui)> btw wasnt there a discussion at some point to rework the autoupdater thingy
[17:39:15]
<Aleks (he/him/il/lui)> (i don't know much about the technical aspect)
[17:39:34]
<tituspijean> I concede I forgot if there was a discussion.
[17:40:26]
<tituspijean> Ah, maybe by making it a declarative process? But my feeling is that the .sh file can be very little generalized 😕
[17:42:14]
<tituspijean> I'm open to help for the PR above btw, the update_file() function fails and I have no idea why. (404 error, like if the file was missing, but there's not reason for that)
[17:42:15]
<Aleks (he/him/il/lui)> hmyeah i don't know much what it looks like
[17:42:45]
<Aleks (he/him/il/lui)> but maybe the part about github ci thing could be centralized idk
[17:42:50]
<Aleks (he/him/il/lui)> otherwise on the long-term it's a pain to maintain the github ci thingy
[17:42:57]
<Aleks (he/him/il/lui)> in each individual repo
[17:43:06]
<Aleks (he/him/il/lui)> but that's just a #yakafokon
[17:43:09]
<tituspijean> > <@Alekswag:matrix.org> but maybe the part about github ci thing could be centralized idk
Ah yeah we can drop the .yml and code our own Actions yes
[17:43:41]
<tituspijean> Like... periodically browse for all the apps and check if they have a updater.sh and run it. Totally doable with PyGithub.
[17:44:12]
<tituspijean> (if I endup understanding how to update a file :p)
[17:44:47]
<Aleks (he/him/il/lui)> zblerg i have no idea how that update_file works :O
[17:44:59]
<Aleks (he/him/il/lui)> but sounds interesting, more standard than some mess i did in the past xD
[17:45:41]
<Aleks (he/him/il/lui)> why `path=contents.path` instead of `path=path` though ?
[17:45:47]
<tituspijean> I tried both 😆
[17:46:21]
<Aleks (he/him/il/lui)> 😬
[17:46:29]
<Aleks (he/him/il/lui)> and does the 404 error contains the failing url ?
[17:51:19]
<tituspijean> nope, it points me to the documentation: https://docs.github.com/fr/rest/repos?apiVersion=2022-11-28#create-or-update-file-content
[17:51:30]
<tituspijean> why says that 404 means "resource not found"
[17:54:28]
<tituspijean> mmmh thanks to `rich` I can see the url of the API (like `https://api.github.com/repos/OWNER/REPO/contents/PATH`) but it's ellipsed
[17:54:37]
<tituspijean> (trying to find how to change that)
[18:02:03]
<tituspijean> grmbl the URL is correct
[19:38:16]
<Salamandar> Hey btw small question
[19:38:31]
<Salamandar> Why store the apps icons in the apps repository instead of the yunohost-apps repository ?
[19:41:35]
<tituspijean> > <@Alekswag:matrix.org> yeah we thought about that, but the big challenge with logos is to have some consistent look, and in particular there are some pretty specific expectations : the logo should be a png square, with either a ~flat color or transparent background, and some important margin between the canvas and the actual logo ... sooo the thing is we clearly don't want to spend countless hours making pull requests on a bunch of repository each time we want to rework the logos to have them consistent
^
[19:42:21]
<tituspijean> Sorry for the ping Aleks 😅
[19:43:18]
<Yunohost Git/Infra notifications> [apps] @Salamandar opened [pull request #1625](https://github.com/YunoHost/apps/pull/1625): Add matrix-appservice-irc, a matrix-irc bridge
[19:50:25]
<tituspijean> > <@Alekswag:matrix.org> btw wasnt there a discussion at some point to rework the autoupdater thingy
found it: https://github.com/YunoHost/example_ynh/pull/187#issuecomment-1247181825
[19:51:57]
<Salamandar> > <@titus:pijean.ovh> found it: https://github.com/YunoHost/example_ynh/pull/187#issuecomment-1247181825
LOL i just went on it 2 minutes ago
[19:52:26]
<Salamandar> i completely forgrot it was pending
[19:52:34]
<tituspijean> I was considering if I could steal your script as a base for the next-generation updater.
[19:53:17]
<tituspijean> Like, updating it to use PyGithub and extended to also create the PR.
[19:54:00]
<Salamandar> pygithub ? dunno about that but why not
[19:54:15]
<Salamandar> Can we agree to merge this PR then you work on it ?
[19:54:18]
<Salamandar> to have nicer diffs ;)
[19:54:26]
<tituspijean> I don't know if it's possible to supersede function declarations in Python? Like, default to the functions there https://github.com/YunoHost/example_ynh/pull/187/files#diff-6aa1d61eedbea87cba026ecc2f0137fac6b296a1197fa66a93be7647bf903b29R27-R61 but read the app-specific files if needed
[19:57:45]
<Salamandar> https://github.com/YunoHost/example_ynh/pull/187 is updated
[19:58:34]
<Salamandar> > <@titus:pijean.ovh> I don't know if it's possible to supersede function declarations in Python? Like, default to the functions there https://github.com/YunoHost/example_ynh/pull/187/files#diff-6aa1d61eedbea87cba026ecc2f0137fac6b296a1197fa66a93be7647bf903b29R27-R61 but read the app-specific files if needed
Ah yeah it's completely possible
[19:58:36]
<Salamandar> needs a bit of black magic though
[19:58:40]
<Salamandar> nothing too horrible
[20:03:28]
<tituspijean> > <@Salamandar:matrix.org> Can we agree to merge this PR then you work on it ?
I actually don't know. If we are to generalize the updater script, its components would be:
1. Main bot in YunoHost/apps/tools/auto-updater with:
1. a `for` loop to cover all repositories in YunoHost-Apps (like in https://github.com/YunoHost/apps/pull/1624)
2. basically your .py script integrated in the `for` loop
2. a .py script in each app repo containing the custom `get_latest_version` and `generate_src_files` functions
[20:03:34]
<Salamandar> this works :
```
try:
import custom
if "get_latest_version" in dir(custom):
get_latest_version = custom.get_latest_version
except ModuleNotFoundError:
pass
```
[20:03:46]
<Salamandar> but there might be an even cleaner way ?
[20:04:50]
<tituspijean> maybe a simple `import that_file` and a `try:` with custom_get_latest_version and `except:` with get_latest_version
[20:04:51]
<Salamandar> you can remove the if test with another except filter
[20:05:32]
<tituspijean> > <@titus:pijean.ovh> maybe a simple `import that_file` and a `try:` with custom_get_latest_version and `except:` with get_latest_version
mmmh nah that would catch any exception in the custom function too
[20:05:58]
<Salamandar> ```
try:
import custom
get_latest_version = custom.get_latest_version
except (AttributeError, ModuleNotFoundError):
pass
```
[20:06:00]
<Salamandar> > <@titus:pijean.ovh> mmmh nah that would catch any exception in the custom function too
indeed
[20:06:13]
<Salamandar> > <@titus:pijean.ovh> I actually don't know. If we are to generalize the updater script, its components would be:
>
> 1. Main bot in YunoHost/apps/tools/auto-updater with:
> 1. a `for` loop to cover all repositories in YunoHost-Apps (like in https://github.com/YunoHost/apps/pull/1624)
> 2. basically your .py script integrated in the `for` loop
> 2. a .py script in each app repo containing the custom `get_latest_version` and `generate_src_files` functions
hmmmm
[20:06:36]
<Salamandar> Does that mean the maintainer can't run the script himself ?
[20:06:48]
<Salamandar> I find myself regularly running the script in the app's repo
[20:06:58]
<tituspijean> erf indeed
[20:07:00]
<Salamandar> (on my non-yunohost, archlinux, laptop)
[20:07:23]
<Salamandar> By the way, when is archlinux supported by Yunohost ?
[20:07:27]
<Salamandar> /s
[20:21:44]
<Aleks (he/him/il/lui)> we need to finish WSL support first wink wink
[20:21:44]
<Aleks (he/him/il/lui)> u wot m8
[20:21:59]
<Aleks (he/him/il/lui)> and rewriting the bash helpers in visual basic
[20:26:53]
<tituspijean> > <@Alekswag:matrix.org> we need to finish WSL support first wink wink
It works perfectly fine. 😝
[20:47:30]
<Salamandar> > <@Alekswag:matrix.org> we need to finish WSL support first wink wink
lol
[20:53:29]
<Salamandar> > <@Alekswag:matrix.org> and rewriting the bash helpers in visual basic
my gf writes batch script for her job, i'm in pain for her
[20:53:37]
<Aleks (he/him/il/lui)> sooooo 😬 I have this cool next iteration Yunorunner pretty much working but "eh", it breaks the jenkins-behind-yunorunner use case and it needs a package_check PR that includes non-backward compatible changes meaning we gotta upgrade all CI once we merge it 😬 https://github.com/YunoHost/yunorunner/pull/48
[20:53:55]
<Aleks (he/him/il/lui)> oooh, batch scripts like *batch* scripts ?
[20:54:13]
<Salamandar> (ho d'ailleurs aucun rapport mais elle cherche une boîte de formation pour se former en python, avec ses crédits CPF de préférence… vous en avez suivi ?)
[20:55:08]
<Aleks (he/him/il/lui)> (Python is love, Python is life)
[20:56:13]
<Salamandar> it is
[20:56:19]
<Salamandar> > <@Alekswag:matrix.org> oooh, batch scripts like *batch* scripts ?
yeah
[20:56:21]
<Salamandar> like WINDOWS
[20:56:28]
<Salamandar> also some powershell scripts
[20:56:40]
<Aleks (he/him/il/lui)> ogod
[22:36:52]
<Yunohost Git/Infra notifications> [nextcloud_ynh] @ericgaspar edited [pull request #535](https://github.com/YunoHost-Apps/nextcloud_ynh/pull/535): opcache.interned_strings_buffer higher 8
[23:03:33]
<Yunohost Git/Infra notifications> Application 13ft rises from level (unknown) to level 7 on https://ci-apps.yunohost.org/ci/job/13392